-
Notifications
You must be signed in to change notification settings - Fork 278
Add support for PEP 738 Android tags #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@brettcannon: You reviewed the similar changes for iOS recently; are you able to take a look at this? |
brettcannon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change to keep the tests a bit more robust.
Co-authored-by: Brett Cannon <brett@python.org>
|
Thanks! @pradyunsg Any chance of getting this released and vendored in time for pip 25.1 next week? The overall plan is in pypa/pip#13299. |
|
I've filed a tracking issue for cutting the release. |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [packaging](https://github.com/pypa/packaging) | project.dependencies | major | `==24.2` -> `==25.0` | --- ### Release Notes <details> <summary>pypa/packaging (packaging)</summary> ### [`v25.0`](https://github.com/pypa/packaging/releases/tag/25.0) [Compare Source](pypa/packaging@24.2...25.0) #### What's Changed - Re-add a test for Unicode file name parsing by [@​Siddhesh-Agarwal](https://github.com/Siddhesh-Agarwal) in pypa/packaging#863 - Upgrade to ruff 0.9.1 by [@​DimitriPapadopoulos](https://github.com/DimitriPapadopoulos) in pypa/packaging#865 - Add support for PEP 738 Android tags by [@​mhsmith](https://github.com/mhsmith) in pypa/packaging#880 - feat(markers): support 'extras' and 'dependency_groups' markers by [@​frostming](https://github.com/frostming) in pypa/packaging#888 #### New Contributors - [@​Siddhesh-Agarwal](https://github.com/Siddhesh-Agarwal) made their first contribution in pypa/packaging#863 - [@​mhsmith](https://github.com/mhsmith) made their first contribution in pypa/packaging#880 - [@​frostming](https://github.com/frostming) made their first contribution in pypa/packaging#888 **Full Changelog**: pypa/packaging@24.2...25.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yNTEuMCIsInVwZGF0ZWRJblZlciI6IjM5LjI1MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/329 Reviewed-by: Luke Tainton <luke@tainton.uk> Co-authored-by: Renovate [BOT] <renovate-bot@git.tainton.uk> Co-committed-by: Renovate [BOT] <renovate-bot@git.tainton.uk>
This tag format was originally defined in PEP 738, and is now documented in the compatibility tag spec.
Like macOS and iOS, we define a public function which yields a sequence of tags from a maximum platform version down to a minimum. However, Android is a bit simpler because its version is expressed as an integer.