Update _hash when unpickling Tag() #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholth
commented
Dec 2, 2024
Member
Author
|
What's stopping this from being merged? |
uranusjr
reviewed
Apr 22, 2025
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
pradyunsg
approved these changes
Apr 27, 2025
Member
|
I'll wait for a week, for @brettcannon to review, if he's available. |
brettcannon
approved these changes
May 9, 2025
Member
|
Thanks for the PR and patience, @dholth ! |
brettcannon
added a commit
that referenced
this pull request
May 12, 2025
Also fix a variable name to be more accurate. Brought up in a comment in #860 .
Merged
brettcannon
added a commit
that referenced
this pull request
May 12, 2025
Also fix a variable name to be more accurate. Brought up in a comment in #860 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #859
Might be nice to omit
_hashfrom__getstate__and create a_cache_hash()function.