Use !r formatter for error messages with filenames. #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I've been tracking an empty filename for some time, and it took me a while to realise it was just here in my logs invisible. So adding !r everywhere, so that at least there is a pair of quotes.
brettcannon
approved these changes
Oct 21, 2024
Member
|
Thanks! |
Contributor
Author
|
Much ❤️ for your work and the speed at which you merge PRs. |
Merged
ewdurbin
added a commit
to pypi/warehouse
that referenced
this pull request
Nov 8, 2024
ewdurbin
added a commit
to pypi/warehouse
that referenced
this pull request
Nov 8, 2024
* chore(deps): bump packaging from 24.1 to 24.2 Bumps [packaging](https://github.com/pypa/packaging) from 24.1 to 24.2. - [Release notes](https://github.com/pypa/packaging/releases) - [Changelog](https://github.com/pypa/packaging/blob/main/CHANGELOG.rst) - [Commits](pypa/packaging@24.1...24.2) --- updated-dependencies: - dependency-name: packaging dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix tests to handle new !r formatting in packaging ref: pypa/packaging#844 ref: pypa/packaging#848 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ee Durbin <ewdurbin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I've been tracking an empty filename for some time, and it took me a while to realise it was just here in my logs invisible.
So adding !r everywhere, so that at least there is a pair of quotes.