fix: macOS platform tags with old macOS SDK#513
Merged
brettcannon merged 2 commits intopypa:mainfrom Jun 17, 2022
Merged
Conversation
brettcannon
requested changes
Mar 2, 2022
Member
brettcannon
left a comment
There was a problem hiding this comment.
I have not had a chance to do a full review, but I do have some asks to tweak the formatting of the comments.
pradyunsg
previously requested changes
Mar 8, 2022
bd3ed22 to
0b1cb9b
Compare
0b1cb9b to
bd36b45
Compare
3b06bae to
0d1175a
Compare
Member
|
@mayeut I just wanted to quickly let you know I have not forgotten about this PR (busy work stuff plus trying to prioritize bugfixes for Python 3.11). |
Member
Author
|
I understand, thanks for letting me know. I'll try to keep it up-to-date in the mean time. |
This retrieves the real macOS version to compute macOS platform tags when the python interpreter is built with an old macOS SDK. fixes pypa#497
brettcannon
approved these changes
Jun 17, 2022
Member
|
Thanks for the PR and your patience. 🙂 |
hrnciar
pushed a commit
to hrnciar/packaging
that referenced
this pull request
Jul 1, 2022
This retrieves the real macOS version to compute macOS platform tags when the python interpreter is built with an old macOS SDK that reports 10.16 as the macOS version. fixes pypa#497 Co-authored-by: Brett Cannon <brett@python.org>
Closed
4 tasks
1 task
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This retrieves the real macOS version to compute macOS platform tags when the python interpreter is built with an old macOS SDK.
fixes #497
There are no official docs from Apple on this. This is based on a couple blog posts linked in #497 and my own observations. Most notably, since there are no docs, I can't be sure that the only effect of Apple's trick is to change the version. There might be other (still undocumented...) side-effects.