Remove warning about packages not containing __init__.py files#151
Merged
Remove warning about packages not containing __init__.py files#151
__init__.py files#151Conversation
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 6, 2022
v63.1.0 Changes Merge with pypa/distutils@152c13d including pypa/distutils#155 (improved compatibility for editable installs on homebrew Python 3.9), pypa/distutils#150 (better handling of runtime_library_dirs on cygwin), and pypa/distutils#151 (remove warnings for namespace packages). v63.0.0 Breaking Changes Drop setuptools' support for installing an entrypoint extra requirements at load time: - the functionality has been broken since v60.8.0. - the mechanism to do so is deprecated (fetch_build_eggs). - that use case (e.g. a custom command class entrypoint) is covered by making sure the necessary build requirements are declared. Documentation changes Updated the example pyproject.toml -- by :user:`jacalata` This updates the documentation for the file_finders hook so that the logging recommendation aligns with the suggestion to not use distutils directly. Fix reference for keywords to point to the Core Metadata Specification instead of PEP 314 (the live standard is kept always up-to-date and consolidates several PEPs together in a single document). Reordered the User Guide's Table of Contents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally distutils implementation did not account for PEP 420 and included warns for package directories that did not contain
__init__.pyfiles.After the acceptance of PEP 420, these warnings don't make more sense and sometimes can confuse users.
Recently this was pointed out in one of
setuptoolsdiscussions: pypa/setuptools#3353 (reply in thread).This PR removes the warning (and adds a test capturing the expectation).
Since the only change is a warning removal, this can be seen as a "progressive enhancement" over the versions of distutils existing in the standard library:
SETUPTOOLS_USE_DISTUTILS=stdlibwill still see the warning, but the build will not fail or change in terms of outcome