Add GraalPy 25 and remove workarounds for that version.#2597
Conversation
4015449 to
3b972fb
Compare
3b972fb to
1ce42d7
Compare
|
Hm, I still see lots of workarounds...! I had expected them to go for some reason, maybe because of how the comments were worded. I'm wondering - did you expect to have a fix release out for GP24 or did I misunderstand? |
|
But yeah, otherwise LGTM! |
I had hoped to have a fix for GP24, but we couldn't get it out and for reasons I have no control over there will not be another release off the GP24 branch, so the workarounds have to stay for that version. Once we decide to drop it, we can remove them entirely. I wouldn't mind dropping it before we release the next version in the spring of next year, i just didn't want to do it without any overlap time in case someone did use a build spec with gp24 in it. |
|
Hm, both the iOS as well as the windows tests seem flaky. They failed, they passed, they failed two times now... this PR shouldn't affect iOS tests, and the Windows tests seem to fail with network connectivity issues (the latest one running on CPython 3.8 afaict, so also not GraalPy related). |
|
Yeah, the iOS tests being flaky is a known issue. The windows failure is test_ssl again, which honestly, I have no idea why it's such a problem child. It does hit the network, but then again, every build hits PyPI, and that's the one that has the problem. I added a flaky marker, but maybe it needs a pause to get around temporary network issues. |
Drops the GraalPy 3.11 / GraalPy 24.2 builds (gp311_242) as agreed in #2741: a ~6-month overlap after the GraalPy 25 (gp312) release. GraalPy 3.12 (gp312_250) stays. This also removes the GraalPy 24-only workarounds that were explicitly marked "Remove when GraalPy 24.x is dropped": - the Visual Studio compiler-discovery (vswhere) and build-isolation (graalpython#491) workarounds in the Windows backend - the issue-491 Windows skip/filter hacks in test_pep518 and test_dependency_versions (added in the original GraalPy PR #1538 and unneeded since GraalPy 25 per #2597) The uv-doesn't-support-graalpy skip (#2754), the `graalpy` enable group, and the generated constraints pins apply to all GraalPy and are kept. Assisted-by: ClaudeCode:claude-opus-4.8
No description provided.