fix: always resolve --python argument#2328
Merged
Conversation
Contributor
|
I also hit the bug when using a |
Contributor
Author
|
Looking into if we can fix the virtualenv creation. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
8f562c8 to
b282da1
Compare
Contributor
Author
|
This fixed it for me, thanks to @zanieb! I can backport, as well (it's in a different path in 2.x). |
Contributor
Author
|
PS: Also tagging @vineetbansal, who I originally found the issue with. |
mayeut
approved these changes
Mar 22, 2025
henryiii
added a commit
to henryiii/cibuildwheel
that referenced
this pull request
Mar 22, 2025
fix: always resolve the --python argument Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
added a commit
that referenced
this pull request
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #2327.
uvx git+https://github.com/henryiii/cibuildwheel@henryiii/fix/uvx --only cp312-pyodide_wasm32does seem to pass with this.Virtualenv can break if the
--pythonargument is a symlink.