build: remove redundant change of working directory#536
Conversation
|
Aren't build hooks inherently thread unsafe due to the requirement that they be called in the source directory? You do not pass the source directory into the build hook, it's not part of the interface defined in PEP 517. So the build hook must require the working directory be the source directory. You look up the pyproject.toml by cwd when implementing a hook, as well as whatever it is supposed to build. A redundant change is fine to remove, but there is always at least one, right? (I'm thinking of doing multiple builds at the same time - ahh, maybe that's not what you are working on here.) |
Do you mean that there is at least one |
|
Thanks for this. Can you add a simple test to validate that a relative path is made absolute by the |
|
I'll rebase this on top of #532 as soon as it's unblocked, don't bother fixing the line no :) |
|
Actually, can you rebase on top of main, @radoering? I don't want to rewrite your history. |
87bf25e to
f5f0165
Compare
|
Thanks! |
As per #535 (comment) changing the working directory seems to be redundant. So let's remove it. (This also makes build thread-safe.)
Closes #535