build: protect _working_directory with lock to make build thread-safe#535
Closed
radoering wants to merge 1 commit into
Closed
build: protect _working_directory with lock to make build thread-safe#535radoering wants to merge 1 commit into
radoering wants to merge 1 commit into
Conversation
Member
|
Hmm, do we actually need to chdir? Isn’t this handled by pep517?
Sent with [Proton Mail](https://proton.me/) secure email.
…------- Original Message -------
On Sunday, November 20th, 2022 at 16:05, Randy Döring ***@***.***> wrote:
***@***.***(https://github.com/radoering) requested your review on: [#535](#535) build: protect _working_directory with lock to make build thread-safe as a code owner.
—
Reply to this email directly, [view it on GitHub](#535 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHNRFWGN7WYESI5TWO2ERDDWJIVZLANCNFSM6AAAAAASF3RCNM).
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Member
|
I'm quite certain this is redundant. |
Contributor
Author
Member
|
I think the issue then was that the source directory wasn't an absolute path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In python-poetry/poetry#6205, we noticed that running multiple builds in parallel is not thread-safe because build changes the working directory at some places. Of course, downstream users can protect calls to
buildwith locks by themselves but it might be nice to not have to worry about it.