Fix incorrect lockfile generation when packageCacheDir is passed without trailing slash#5763
Merged
ryanking13 merged 4 commits intoJul 15, 2025
Conversation
1 task
hoodmane
reviewed
Jul 13, 2025
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
for more information, see https://pre-commit.ci
hoodmane
approved these changes
Jul 15, 2025
hoodmane
left a comment
Member
There was a problem hiding this comment.
Thanks!
We also have the problem that the package cache doesn't work with absolute file paths but that can be dealt with separately.
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Jul 31, 2025
…out trailing slash (pyodide#5763) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Jul 31, 2025
…out trailing slash (pyodide#5763) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Aug 4, 2025
…out trailing slash (pyodide#5763) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Aug 4, 2025
…out trailing slash (pyodide#5763) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes pyodide/micropip#241 (comment). I also added some testcase regarding
packageCacheDir. I don't think it needs a change log as it is related to the new behavior in micropip 0.10.1 which isn't included in 0.28.0Checklist