Skip wasm-gc on iOS Safari where it's borked #5445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
6324ebd to
3432a3b
Compare
agriyakhetarpal
approved these changes
Feb 21, 2025
hoodmane
reviewed
Feb 21, 2025
cpython/patches/0009-Skip-wasm-gc-on-iOS-Safari-where-it-s-broken.patch
Outdated
Show resolved
Hide resolved
Member
|
We will need to update the patch here once @freakboy3742's upstream review is addressed. |
Closed
e586391 to
cb7e0de
Compare
Member
|
Okay merging since upstream pr was merged. Thanks @freakboy3742 and @ambv! |
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 24, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Feb 26, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418. macOS Safari 18.3 does not surface the issue. Confirmed on device that disabling this restores interpreter function. Resolves pyodide#5428.
| -addOnPreRun(() => { | ||
| + | ||
| +function getPyEMCountArgsPtr() { | ||
| + let isIOS = globalThis.navigator && /iPad|iPhone|iPod/.test(navigator.platform); |
Contributor
There was a problem hiding this comment.
ouch ... was this really an iOS only thing? I understand the ugly workaround but I wonder how comes iOS would branch that much from iPad and I had a honest little laugh at reading iPod in there 😁 (nostalgic personal hysterical laugh I believe)
This also won't play well at all once they fix their issue ... UA sniffing demands maintenance, which is why is usually, and rightly so, discouraged (sometimes inevitable though).
There was a problem hiding this comment.
So - it's been reported on iOS 18.3.1; iPads running it (or... in theory, iPods, but I don't know if there's any actually still supported that could run iPod) should also be affected, but I can't say I've tried personally.
And I completely agree that UA sniffing isn't an ideal solution - but the perfect is the enemy of the good until we're able to determine a better underlying fix based on sniffing specific behavior. At this point, all we know is "iOS 18.3.1(+?) bad", and we have a fallback.
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request: python/cpython#130418.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.
Resolves #5428.