Use webassembly exception handling#5320
Conversation
25955b8 to
3fa4817
Compare
|
The only core test failure is |
|
Clarabel has to be disabled until they resolve a problem with the newest beta rust. |
It's a bit hard to make the rust compiler play along, see the upstream PR for the rust difficulties pyodide/pyodide-build#81
for more information, see https://pre-commit.ci
Today's nightly is the first one with all the commits needed for wasm eh pyodide#5320. Bump the main branch to use the same rust version.
|
@agriyakhetarpal @ryanking13 I think all tests are passing now, would appreciate if you could review this and pyodide/pyodide-build#81. |
|
Thanks for working on this Hood. I'll review it soon, probably before this weekend. |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks for the ping here, @hoodmane. I can't say I understand all of the details, but it looks good to me – I'll be echoing some of @ryanking13's previous comments.
|
I remember that |
|
Yes everyone downstream needs to pass |
|
But it'll be a bit annoying if they want to build for both Pyodide 0.27 and Pyodide 0.28 since they need different flags. |
|
Yes, that would be a breaking change for |
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
|
I should clarify further about sjlj in the changelog. |
for more information, see https://pre-commit.ci
ryanking13
left a comment
There was a problem hiding this comment.
Thanks @hoodmane! Codewise looks good to me. Could you please address the comments that I had left in the pyodide-build side changes? pyodide/pyodide-build#81
Specifically, I think a comment regarding sjlj flag needs to be addressed, as the flag has been changed in the latest version of emscripten.
|
Okay let's merge it =D |
It's a bit hard to make the rust compiler play along, see the upstream PR for information about the rust difficulties pyodide/pyodide-build#81
Based on / supersedes #3817
Build failures
Import failures
These use setjmp/longjmp and have errors because the symbols for setjmp/longjmp are missing.