Skip to content

Add CHANGELOG entry for #4719, skip PROPACK test for scipy.sparse.linalg._eigen#5000

Merged
agriyakhetarpal merged 3 commits intopyodide:mainfrom
agriyakhetarpal:fix/changelog-4719
Aug 10, 2024
Merged

Add CHANGELOG entry for #4719, skip PROPACK test for scipy.sparse.linalg._eigen#5000
agriyakhetarpal merged 3 commits intopyodide:mainfrom
agriyakhetarpal:fix/changelog-4719

Conversation

@agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Aug 10, 2024

Description

Missed adding this in #4719, adding it here. This fixes a timeout with the CircleCI checks coming from a failing SciPy test (which is skipped in GHA).

Checklists

N/A

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agriyakhetarpal! Could you also update the test to skip the failing one?

I see that the test_SVDS_PROPACK test that we skip for GHA test-scipy job is running on CircleCI, which causes the function signature mismatch. It causes other tests to time out.

@agriyakhetarpal
Copy link
Member Author

Yes, I was thinking of doing it here – I didn't find anything as to why CircleCI runs it when GHA skips it (at least, related to my PR). I'll take a look further.

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Aug 10, 2024

I guess when running the tests on the scipy trigger, the GHA job runs mv scipy-conftest.py conftest.py to rename it, but the CircleCI jobs don't, so --runtime=firefox-no-host packages/*/test*.py --skip-passed won't pick up the configuration from that file. That doesn't explain how it worked before my PR, though, so my hunch is that checking for the commit message for [scipy] and renaming scipy-conftest.py should also be pursued in the CircleCI steps/jobs.

@agriyakhetarpal
Copy link
Member Author

Found it, it's failing because of this line:

runtest("sparse.linalg._eigen", "test_svds_parameter_k_which")

@agriyakhetarpal agriyakhetarpal changed the title Add CHANGELOG entry for #4719 Add CHANGELOG entry for #4719, skip PROPACK test for scipy.sparse.linalg._eigen Aug 10, 2024
@agriyakhetarpal
Copy link
Member Author

Some of the tests might have been skipped because of the pytest caching, but I think this should be safe to merge now – I verified locally in an IPython shell (in SciPy, this is python dev.py ipython) that this runs the ARPACK and LOBPCG tests, and the PROPACK ones are skipped.

@agriyakhetarpal agriyakhetarpal merged commit 28f3510 into pyodide:main Aug 10, 2024
@agriyakhetarpal agriyakhetarpal deleted the fix/changelog-4719 branch August 10, 2024 12:40
agriyakhetarpal added a commit to agriyakhetarpal/pyodide that referenced this pull request Aug 10, 2024
Also add an entry for gensim which was upgraded in pyodide#4719 and missed in pyodide#5000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants