Fix pyodide-build verbose log by replacing requests with urllib#4814
Merged
ryanking13 merged 4 commits intopyodide:mainfrom Jun 5, 2024
Merged
Fix pyodide-build verbose log by replacing requests with urllib#4814ryanking13 merged 4 commits intopyodide:mainfrom
ryanking13 merged 4 commits intopyodide:mainfrom
Conversation
1 task
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Jun 7, 2024
…ide#4814) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve: #4810
This is a kind of a temporary fix for #4810. The log comes from requests (urllib3), so this PR replaces requests with urllib. I'll try to refactor our logger module to fix the root cause, but I guess it will take some time, hence this PR.
Unfortunately, I couldn't write a test as it was impossible for me to reproduce the error in pytest. I guess it has something to do with how pytest handles logging but I am not sure.
Checklists