Fix build error on pypa/build >= 1.2.0#4653
Merged
ryanking13 merged 10 commits intopyodide:mainfrom Mar 31, 2024
Merged
Conversation
hoodmane
approved these changes
Mar 30, 2024
Member
hoodmane
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @ryanking13!
4 tasks
Member
Author
|
Also updated lightgbm version to make it compatible to build>=1.1.0 (pypa/build#716) |
ryanking13
added a commit
to ryanking13/pyodide
that referenced
this pull request
Mar 31, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We started getting build errors after pypa/build release 1.2.0.
The private attribute we were using
isolated_env._scripts_dirwas removed in the new pypa/build release as they started to support multiple installers. This PR fixes it + pins pypa/build minor version.