Replace pkgconfig with pkg-config for Meson configuration file#4550
Merged
hoodmane merged 1 commit intopyodide:mainfrom Feb 23, 2024
Merged
Conversation
Member
Author
|
Hi @hoodmane, I think this should work – please let me know if this requires a CHANGELOG entry or if this is too minor for doing so. I don't see anything about this in the documentation either, but it is possible I may have missed something. |
ryanking13
pushed a commit
to ryanking13/pyodide
that referenced
this pull request
Mar 30, 2024
…yodide#4550) Removes a depreciation warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a small fix to silence a Meson deprecation warning, where the
pkgconfigentry in the Meson cross-configuration file has to be replaced by the termpkg-config. This is referenced in the following lines:https://github.com/mesonbuild/meson/blob/39e1bf19fb653ac4f040e48b9a33aaa59dea1196/mesonbuild/envconfig.py#L399-L404
Closes #4540
Checklists