New packages ppl, pplpy (Parma polyhedra library), cysignals#4407
New packages ppl, pplpy (Parma polyhedra library), cysignals#4407hoodmane merged 14 commits intopyodide:mainfrom
Conversation
ryanking13
left a comment
There was a problem hiding this comment.
Thanks @mkoeppe! It looks like the test is failing because pplpy test is failing because it depends on gmpy2. We would also need some basic tests for pplpy.
|
|
||
| # from https://pyodide.org/en/stable/development/building-from-sources.html#using-make: | ||
| # - build-essential | ||
| # we install file because it is used by packages/ppl during configure |
There was a problem hiding this comment.
Well, I'm a little hesitant about installing a tool to install a less common package, but file is a very common tool (I am quite surprised that it is not installed by default in the vscode devcontainer), so it's probably fine.
There was a problem hiding this comment.
Or, probably you can put it into environment.yml.
There was a problem hiding this comment.
In this particular case, the configure script appears to look for it specifically in /usr/bin, which is weird and could be patched out of course, but just installing in with apt is the easiest solution. As you say, file is a common tool; so it will certainly be present on typical developers' machines.
| host: | ||
| - libgmp | ||
| - ppl | ||
| - gmpy2 |
There was a problem hiding this comment.
This is a python package need in runtime. So you need to put this in
requirements:
run:
- gmpy2
for more information, see https://pre-commit.ci
|
Passes tests now, ready for review |
| From: Roberto Bagnara <bagnara@cs.unipr.it> | ||
| Date: Sun, 11 Feb 2018 08:11:09 +0000 (+0100) | ||
| Subject: Added missing "template" and "typename" keywords. | ||
| X-Git-Url: http://www.cs.unipr.it/git/gitweb.cgi?p=ppl%2Fppl.git;a=commitdiff_plain;h=c39f6a07b51f89e365b05ba4147aa2aa448febd7;hp=3a5e1e20a94cffb830182f22132b153d6691b7c5 |
There was a problem hiding this comment.
Is this a backport? It's an old commit, surely there is a release since then. Are we pinning an old version for some reason? Are we expecting to get rid of it at some point?
Not a merge blocker but if you have answers to any of these questions it would be helpful to add them to the patch.
There was a problem hiding this comment.
This version of PPL, 1.2, is unfortunately the latest upstream version - https://repology.org/project/ppl/versions
For the packages that I'm adding, I am using the patches carried by the SageMath distribution - see https://github.com/sagemath/sage/tree/develop/build/pkgs/ppl
There was a problem hiding this comment.
Great, could you copy this comment into the patch file below the original commit message?
| -#if HAVE_SIGALTSTACK | ||
| +#if HAVE_SIGALTSTACK && !defined(__EMSCRIPTEN__) |
There was a problem hiding this comment.
Could you add some more information here? What goes wrong without this patch? Compiler error? Runtime error? Should HAVE_SIGALTSTACK be false in Emscripten?
There was a problem hiding this comment.
As indicated in the commit message with the patch, this is sagemath/cysignals#197, where I explain the details
Description
Checklists