Add a exports/types field to package.json#3975
Merged
ryanking13 merged 1 commit intopyodide:mainfrom Jul 5, 2023
Merged
Conversation
Forgive me if this isn't right, but don't we need to export the types as well?
Member
|
Thanks, but I think we have top-level Line 131 in 50b5e1c |
Contributor
Author
|
Here is a small reproduction of what I encountered: When hovering, it gives the suggestion to modify the
So I gave that a shot, and it cleared the error and gave me proper types:
|
ryanking13
approved these changes
Jul 5, 2023
Member
ryanking13
left a comment
There was a problem hiding this comment.
Thanks for the repro @khill-fbmc! After reading the typescript docs, it looks like this is the right change.
Contributor
Author
|
Happy to help :) This is a really cool project! |
Member
|
Thanks @khill-fbmc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgive me if this isn't right, but don't we need to export the types as well?
Description
I was having trouble in VSCode with no type hints
Solution
Add
"types": "./pyodide.d.ts"to the exports definition.