ENH Add environment variable to control 'exports' cli argument#3973
ENH Add environment variable to control 'exports' cli argument#3973hoodmane merged 17 commits intopyodide:mainfrom
Conversation
If "exports" is not passed as a CLI argument, check for an environment variable called PYODIDE_EXPORTS. If this is also missing, default to "requested".
for more information, see https://pre-commit.ci
…odide into exports-environment-variable
ef15ee1 to
b078e31
Compare
for more information, see https://pre-commit.ci
|
Not at computer, but Typer (if that’s what you are using) has integrated support for envvars: https://typer.tiangolo.com/tutorial/arguments/envvar/ (most CLI parsers do). |
|
Ah great thanks for pointing that out @henryiii. |
|
Thanks! Could you also document it under https://pyodide.org/en/stable/development/building-from-sources.html#environment-variables ? Maybe it would make sense to have something more specific? Like |
…odide into exports-environment-variable
|
@rth @ryanking13 could one of you give this a quick review? I want to backport it to 0.23.4 and it's the last thing I want to add to that release. |
ryanking13
left a comment
There was a problem hiding this comment.
Thanks, @hoodmane! and sorry for the late review. I have some minor comments otherwise LGTM. Please also update the changelog.
|
Nice! LGTM as well and CI is green. |
If "--exports" is not passed as a CLI argument, check for an environment variable called PYODIDE_EXPORTS. If this is also missing, default to "requested".
cc @henryiii
Checklists