Add url parameter to install_xbuildenv #3592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
Feb 20, 2023
1 task
rth
approved these changes
Feb 20, 2023
| str(envpath), | ||
| "--download", | ||
| "--url", | ||
| "https://github.com/pyodide/pyodide/releases/download/0.22.1/xbuildenv-0.22.1.tar.bz2", |
Member
There was a problem hiding this comment.
It's a 10MB file, not sure about downloading it each time this test is run. At least maybe we could put it behind some pytest mark and not run it by default?
If we cannot create a similar archive for testing at runtime that is.
Member
Author
There was a problem hiding this comment.
If we cannot create a similar archive for testing at runtime that is.
I'll try this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #3567
Adds url paramter to
install_xbuildenv, which helps installing xbuildenv from arbitrary URL. This is mostly for developers / maintainers who want to test tot xbuildenv.This PR also adds a private CLI entrypoint
pyodide xbuildenv install.Checklists