Add vendor-sharedlib key in meta.yaml spec#3234
Merged
ryanking13 merged 8 commits intopyodide:mainfrom Nov 9, 2022
Merged
Conversation
hoodmane
approved these changes
Nov 9, 2022
hoodmane
added a commit
that referenced
this pull request
Nov 9, 2022
This is needed to finish getting numpy tests working. It won't work for packages that need shared libraries without some extra intervention. ryanking's work in #3234 would help to fix this. pip install scipy makes the command line runner extremely slow. Without scipy installed, python -c 'print(1)' runs in about 1 second, but with it installed it takes more like 10 seconds (time to load clapack_all.so and 111 different .so files in scipy, totaling 20 megabytes). We have to load all of this despite the fact that we won't use any of it.
Member
|
Nice to see more use of auditwheel-emscripten, thanks @ryanking13 ! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is anothor split from #3183.
This adds
vendor-sharedlibkey. If set to True, pyodide-build will copy shared libs into the wheel file after build.It is similiar to
auditwheel repair, but without modifying RPATH.Since there is no such thing like RPATH in Emscripten WASM module, we need to manage it manually in JS side (which will be a last split up PR for #3183).
Note that
vendor-sharedlibis default to False. So no packages are affected by this PR itself.Checklists