Merged
Conversation
phorward
approved these changes
Nov 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the pytest test discovery with the following points,
pytestwith no arguments (orpytest .) now correctly collects all available tests (except for emsdk ones which require the compiler setup and have to be run separately withmake -C emsdk test)pyteston packages now skips package tests that are not built. This is done at the selenium fixture level and so will also apply to new tests.packages/test_packages_common.py::test_importnow will skip the test before loading the selenium_standalone fixture which is slow. Previously it was first loading the slow fixture, and then skipping.make testas I think pytest should not be used via make, as then one loses access to all useful flags (e.g.--pdb,-n auto(for parallelism),-sfor printing stdout, etc)Closes #1979