Skip to content

make test in docker always fails due broken emsdk/tests #1979

@phorward

Description

@phorward

🐛 Bug

Hey, is the emsdk/tests-suite broken or sort of? When I want to run the test suite locally in a docker container, it always fails.

make test produces this immediately on current main branch:

pytest src emsdk/tests packages/*/test* pyodide-build -v
============================= test session starts ==============================
platform linux -- Python 3.9.5, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/src/.hypothesis/examples')
rootdir: /src, configfile: setup.cfg
plugins: hypothesis-6.14.2, asyncio-0.15.1, cov-2.12.1, forked-1.3.0, httpserver-1.0.0, instafail-0.4.2, rerunfailures-10.1, xdist-2.3.0
collecting ... collected 2653 items / 5 errors / 2 skipped / 2646 selected

==================================== ERRORS ====================================
____________________ ERROR collecting emsdk/tests/common.py ____________________
/usr/local/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1030: in _gcd_import
    ???
<frozen importlib._bootstrap>:1007: in _find_and_load
    ???
<frozen importlib._bootstrap>:984: in _find_and_load_unlocked
    ???
E   ModuleNotFoundError: No module named 'tests.common'
_________________ ERROR collecting emsdk/tests/test_dyncall.py _________________
/usr/local/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1030: in _gcd_import
    ???
<frozen importlib._bootstrap>:1007: in _find_and_load
    ???
<frozen importlib._bootstrap>:984: in _find_and_load_unlocked
    ???
E   ModuleNotFoundError: No module named 'tests.test_dyncall'
_________________ ERROR collecting emsdk/tests/test_dyncall.py _________________
ImportError while importing test module '/src/emsdk/tests/test_dyncall.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
E   ModuleNotFoundError: No module named 'tests.test_dyncall'
_________________ ERROR collecting emsdk/tests/test_emulate.py _________________
/usr/local/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1030: in _gcd_import
    ???
<frozen importlib._bootstrap>:1007: in _find_and_load
    ???
<frozen importlib._bootstrap>:984: in _find_and_load_unlocked
    ???
E   ModuleNotFoundError: No module named 'tests.test_emulate'
_________________ ERROR collecting emsdk/tests/test_emulate.py _________________
ImportError while importing test module '/src/emsdk/tests/test_emulate.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
E   ModuleNotFoundError: No module named 'tests.test_emulate'
=========================== short test summary info ============================
ERROR emsdk/tests/common.py - ModuleNotFoundError: No module named 'tests.com...
ERROR emsdk/tests/test_dyncall.py - ModuleNotFoundError: No module named 'tes...
ERROR emsdk/tests/test_dyncall.py
ERROR emsdk/tests/test_emulate.py - ModuleNotFoundError: No module named 'tes...
ERROR emsdk/tests/test_emulate.py
!!!!!!!!!!!!!!!!!!! Interrupted: 5 errors during collection !!!!!!!!!!!!!!!!!!!!
========================= 2 skipped, 5 errors in 1.62s =========================
make: *** [Makefile:128: test] Error 2

When I only run

pytest src packages/*/test* pyodide-build -v

it looks much better and as expected.

To Reproduce

  • Checkout current main branch
  • ./run_docker
  • make && make test

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions