Merged
Conversation
Pierre-Sassoulas
approved these changes
May 16, 2024
Member
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
LGTM. I think the numpy cleanup make sense too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2437 +/- ##
==========================================
+ Coverage 92.78% 92.79% +0.01%
==========================================
Files 94 94
Lines 11102 11109 +7
==========================================
+ Hits 10301 10309 +8
+ Misses 801 800 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2024
(cherry picked from commit ee06feb)
jacobtylerwalls
added a commit
that referenced
this pull request
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Needed for the pylint feature flag in pylint-dev/pylint#9632
Refs pylint-dev/pylint#9626