False positive unsubscriptable-object#2307
Merged
jacobtylerwalls merged 5 commits intoSep 26, 2023
Merged
Conversation
- Raise an `InferenceError` when there is a `SyntaxError` due to an invalid `TypeVar` name. Closes pylint-dev#2305 Closes pylint-dev/pylint#9069
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 94 94
Lines 11053 11056 +3
=======================================
+ Hits 10263 10266 +3
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
I'm thinking of adding the test examples from this issue and pylint-dev/pylint#9069 to the Pylint functional tests. |
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Member
Author
|
Tests: pylint-dev/pylint#9071 |
jacobtylerwalls
approved these changes
Sep 26, 2023
jacobtylerwalls
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick work!
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
Fix a regression in 2.15.7 for ``unsubscriptable-object``. Raise an `InferenceError` when there is a `SyntaxError` due to an invalid `TypeVar` name. This reverts commit 89dfb48. Closes #2305 Closes pylint-dev/pylint#9069 (cherry picked from commit 1f0f2f8)
jacobtylerwalls
pushed a commit
that referenced
this pull request
Sep 26, 2023
Fix a regression in 2.15.7 for ``unsubscriptable-object``. Raise an `InferenceError` when there is a `SyntaxError` due to an invalid `TypeVar` name. This reverts commit 89dfb48. Closes #2305 Closes pylint-dev/pylint#9069 (cherry picked from commit 1f0f2f8) Co-authored-by: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
unsubscriptable-object(regression in 2.15.7).InferenceErrorif theTypeVarnaming is invalid.Closes #2305