Fix a crash when _filter_stmts encounters an EmptyNode#1534
Merged
jacobtylerwalls merged 3 commits intopylint-dev:mainfrom Apr 30, 2022
Merged
Fix a crash when _filter_stmts encounters an EmptyNode#1534jacobtylerwalls merged 3 commits intopylint-dev:mainfrom
_filter_stmts encounters an EmptyNode#1534jacobtylerwalls merged 3 commits intopylint-dev:mainfrom
Conversation
Pull Request Test Coverage Report for Build 2239616454
💛 - Coveralls |
DanielNoord
reviewed
Apr 28, 2022
DanielNoord
approved these changes
Apr 28, 2022
Pierre-Sassoulas
approved these changes
Apr 29, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
May 2, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An assertion was added in 864d2f3 "to be removed later".
EmptyNodewas failing the condition, see also related issue pylint-dev/pylint#2535. This PR removes the assertion and short-circuits.Type of Changes
Related Issue
Closes pylint-dev/pylint#6438. Added a regression test without Qt.