Fix instance_attrs building error in Qt brain#1505
Merged
jacobtylerwalls merged 8 commits intopylint-dev:mainfrom Apr 14, 2022
Merged
Fix instance_attrs building error in Qt brain#1505jacobtylerwalls merged 8 commits intopylint-dev:mainfrom
jacobtylerwalls merged 8 commits intopylint-dev:mainfrom
Conversation
1 task
cf1c815 to
9e0ac95
Compare
jacobtylerwalls
commented
Apr 9, 2022
Pull Request Test Coverage Report for Build 2148474445
💛 - Coveralls |
Member
Author
|
Adding the typing changes but not the functional change yields: |
jacobtylerwalls
commented
Apr 9, 2022
DanielNoord
requested changes
Apr 11, 2022
Collaborator
DanielNoord
left a comment
There was a problem hiding this comment.
Change itself looks good (and a pretty big oversight when this created). Some minor other comments.
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
DanielNoord
approved these changes
Apr 11, 2022
Pierre-Sassoulas
approved these changes
Apr 11, 2022
Collaborator
|
@jacobtylerwalls Shall we merge this? CI failures are unrelated. |
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Apr 19, 2022
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
| python-version: ${{ env.DEFAULT_PYTHON }} | ||
| - name: Install Qt | ||
| run: | | ||
| sudo apt-get install build-essential libgl1-mesa-dev |
Contributor
There was a problem hiding this comment.
As mentioned over in #1531 (comment):
I'm confused - why does "Install Qt" actually only do
sudo apt-get install build-essential libgl1-mesa-dev? You are installing PyQt from binary wheels, so that 40s step can probably just be dropped entirely.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix root cause of pylint-dev/pylint#6221.
instance_attrsshould have a list, not a bare Node:https://github.com/PyCQA/astroid/blob/6578a7d04dc28a539402dc27ef50ac756bc9a6d7/astroid/nodes/scoped_nodes/scoped_nodes.py#L1135
Type of Changes
Related Issue
Closes pylint-dev/pylint#6221
Supersedes pylint-dev/pylint#6235