Merge mapping file generation scripts#2152
Merged
jeanas merged 2 commits intopygments:masterfrom May 29, 2022
Merged
Conversation
Use a unified script, to reduce code duplication and in preparation for doing a similar thing with styles and filters. The new script also uses a bit more modern Python APIs (e.g., pathlib). Unlike the previous scripts, it does not replace replace CRLF with LF because Git should do that itself.
Anteru
approved these changes
May 29, 2022
Collaborator
Anteru
left a comment
There was a problem hiding this comment.
This is a good change to remove duplicated code and consolidate functionality. I have only very minor comments, feel free to merge without changes if you don't agree.
Contributor
Author
|
Thanks for the quick review! I've addressed your comments. |
Anteru
approved these changes
May 29, 2022
Collaborator
|
Thanks for the quick changes. Feel free to merge. |
Member
|
Very nice simplification, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a unified script, to reduce code duplication and in preparation
for doing a similar thing with styles and filters. The new script
also uses a bit more modern Python APIs (e.g., pathlib).
Unlike the previous scripts, it does not replace replace CRLF with LF
because Git should do that itself.
I'd like to introduce a new plugin API, and the patch is getting somewhat large, so I'm trying to get some parts of it out of the way.