Skip to content

all: use yield from#1537

Merged
Anteru merged 1 commit intomasterfrom
yield-from
Sep 6, 2020
Merged

all: use yield from#1537
Anteru merged 1 commit intomasterfrom
yield-from

Conversation

@birkenfeld
Copy link
Copy Markdown
Member

No description provided.

@birkenfeld birkenfeld requested a review from Anteru September 5, 2020 18:59
def get_tokens_unprocessed(self, text):
for index, token, value in \
RegexLexer.get_tokens_unprocessed(self, text):
yield index, token, value
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed wholesale? I presume because that's equivalent to the parent class implementation?

Copy link
Copy Markdown
Member Author

@birkenfeld birkenfeld Sep 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the parent class is RegexLexer, AFAICS it just delegates everything to it.

Copy link
Copy Markdown
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I do have did have questions.

@Anteru Anteru merged commit 40baa94 into master Sep 6, 2020
@Anteru Anteru self-assigned this Sep 6, 2020
@Anteru Anteru added the changelog-update Items which need to get mentioned in the changelog label Sep 6, 2020
@Anteru Anteru added this to the 2.7 milestone Sep 6, 2020
@Anteru Anteru deleted the yield-from branch September 6, 2020 12:35
@Anteru Anteru removed the changelog-update Items which need to get mentioned in the changelog label Sep 8, 2020
Kenny2github pushed a commit to Kenny2github/pygments that referenced this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants