Skip to content

Add versioneer and geos_version#43

Merged
caspervdw merged 3 commits intomasterfrom
casper-version
Sep 16, 2019
Merged

Add versioneer and geos_version#43
caspervdw merged 3 commits intomasterfrom
casper-version

Conversation

@caspervdw
Copy link
Copy Markdown
Member

@caspervdw caspervdw commented Sep 14, 2019

Following #42 . This doesn't include the release notes.

@caspervdw caspervdw changed the title Casper version Add versioneer and geos_version Sep 14, 2019
jorisvandenbossche
jorisvandenbossche reviewed Sep 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

This might also be useful: https://github.com/geopandas/geopandas/wiki/Release-checklist. It's my short checklist for when I do geopandas releases

setup.cfg
style = pep440
versionfile_source = pygeos/_version.py
versionfile_build = pygeos/_version.py
tag_prefix =
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche Sep 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to what we have in pandas/geopandas, there we also have a parentdir_prefix entry.
But, I don't really understand what this is supposed to do (and tested this branch, which seems to work correctly to set the version and to create sdists)

Copy link
Copy Markdown
Member Author

@caspervdw caspervdw Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with and without and saw no difference either.. also not sure what it is about.

@caspervdw caspervdw merged commit 6d8f59a into master Sep 16, 2019
@caspervdw caspervdw deleted the casper-version branch September 16, 2019 11:55
@caspervdw
Copy link
Copy Markdown
Member Author

caspervdw commented Sep 16, 2019

0.4 is out! I took the liberty of copying your release checklist

@jorisvandenbossche
Copy link
Copy Markdown
Member

jorisvandenbossche commented Sep 17, 2019

Thanks! And installing it from conda forge is working nicely :)

Collecting package metadata (current_repodata.json): done
Solving environment: done

## Package Plan ##

  environment location: /home/joris/miniconda3/envs/test-pygeos

  added / updated specs:
    - pygeos
    - python=3.7


The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    geos-3.7.2                 |       he1b5a44_2         877 KB  conda-forge
    pygeos-0.4                 |   py37hec07ddf_0          42 KB  conda-forge
    ------------------------------------------------------------
                                           Total:         919 KB

The following NEW packages will be INSTALLED:

  _libgcc_mutex      pkgs/main/linux-64::_libgcc_mutex-0.1-main
  bzip2              conda-forge/linux-64::bzip2-1.0.8-h516909a_1
  ca-certificates    conda-forge/linux-64::ca-certificates-2019.9.11-hecc5488_0
  certifi            conda-forge/linux-64::certifi-2019.9.11-py37_0
  geos               conda-forge/linux-64::geos-3.7.2-he1b5a44_2
  libblas            conda-forge/linux-64::libblas-3.8.0-12_openblas
  libcblas           conda-forge/linux-64::libcblas-3.8.0-12_openblas
  libffi             conda-forge/linux-64::libffi-3.2.1-he1b5a44_1006
  libgcc-ng          pkgs/main/linux-64::libgcc-ng-9.1.0-hdf63c60_0
  libgfortran-ng     pkgs/main/linux-64::libgfortran-ng-7.3.0-hdf63c60_0
  liblapack          conda-forge/linux-64::liblapack-3.8.0-12_openblas
  libopenblas        conda-forge/linux-64::libopenblas-0.3.7-h6e990d7_1
  libstdcxx-ng       pkgs/main/linux-64::libstdcxx-ng-9.1.0-hdf63c60_0
  ncurses            conda-forge/linux-64::ncurses-6.1-hf484d3e_1002
  numpy              conda-forge/linux-64::numpy-1.17.2-py37h95a1406_0
  openssl            conda-forge/linux-64::openssl-1.1.1c-h516909a_0
  pip                conda-forge/linux-64::pip-19.2.3-py37_0
  pygeos             conda-forge/linux-64::pygeos-0.4-py37hec07ddf_0
  python             conda-forge/linux-64::python-3.7.3-h33d41f4_1
  readline           conda-forge/linux-64::readline-8.0-hf8c457e_0
  setuptools         conda-forge/linux-64::setuptools-41.2.0-py37_0
  sqlite             conda-forge/linux-64::sqlite-3.29.0-hcee41ef_1
  tk                 conda-forge/linux-64::tk-8.6.9-hed695b0_1003
  wheel              conda-forge/linux-64::wheel-0.33.6-py37_0
  xz                 conda-forge/linux-64::xz-5.2.4-h14c3975_1001
  zlib               conda-forge/linux-64::zlib-1.2.11-h516909a_1006


Proceed ([y]/n)? 
...
(base) joris@joris-XPS-13-9380:~/scipy$ conda activate test-pygeos
(test-pygeos) joris@joris-XPS-13-9380:~/scipy$ python
Python 3.7.3 | packaged by conda-forge | (default, Jul  1 2019, 21:52:21) 
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pygeos import box, area, intersection
>>> polygons_x = box(range(5), 0, range(10, 15), 10)
>>> polygons_y = box(0, range(5), 10, range(10, 15))
>>> area(intersection(polygons_x[:, None], polygons_y[None, :]))
array([[100.,  90.,  80.,  70.,  60.],
       [ 90.,  81.,  72.,  63.,  54.],
       [ 80.,  72.,  64.,  56.,  48.],
       [ 70.,  63.,  56.,  49.,  42.],
       [ 60.,  54.,  48.,  42.,  36.]])

@jorisvandenbossche jorisvandenbossche mentioned this pull request Sep 30, 2019
Closed
jorisvandenbossche pushed a commit to jorisvandenbossche/shapely that referenced this pull request Nov 29, 2021
@caspervdw
Merge pull request pygeos/pygeos#43 from caspervdw/casper-version
0652072 
Add versioneer and geos_version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caspervdw @jorisvandenbossche