Integrate previously prepared geometries into STRtree query / bulk query#246
Merged
brendan-ward merged 2 commits intopygeos:masterfrom Nov 15, 2020
brendan-ward:issue235
Merged
Integrate previously prepared geometries into STRtree query / bulk query#246brendan-ward merged 2 commits intopygeos:masterfrom brendan-ward:issue235
brendan-ward merged 2 commits intopygeos:masterfrom
brendan-ward:issue235
Conversation
caspervdw
approved these changes
Nov 15, 2020
jorisvandenbossche
pushed a commit
to jorisvandenbossche/shapely
that referenced
this pull request
Nov 29, 2021
Integrate previously prepared geometries into STRtree query / bulk query
jorisvandenbossche
pushed a commit
to jorisvandenbossche/shapely
that referenced
this pull request
Nov 29, 2021
Integrate previously prepared geometries into STRtree query / bulk query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #235
The overall strategy is to fetch both the original and prepared geometry from the
GeometryObject, and only prepare internally withinevaluate_predicateif not previously prepared.Checked with valgrind to make sure we're not leaving prepared geometries around accidentally.
I discovered and corrected an autoformatting issue with the doc string for
evaluate_predicate, hence the larger number of lines changed (the autoformatter previously rolled all params into single paragraph, to avoid this I made them separated by lines).