Skip to content

Conversation

@hardikpnsp
Copy link
Contributor

@hardikpnsp hardikpnsp commented Aug 6, 2022

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • adds support for uninstalling multiple python version at once using pyenv uninstall
  • updates docs (and man pages entries?)

Tests

  • replaces unit test too many arguments for pyenv-uninstall with more than one argument for pyenv-uninstall
  • adds test for pyenv-uninstall hooks for the multiple version scenario

@hardikpnsp hardikpnsp changed the title Add support for multiple versions in pyenv uninstall WIP: Add support for multiple versions in pyenv uninstall Aug 6, 2022
@hardikpnsp hardikpnsp changed the title WIP: Add support for multiple versions in pyenv uninstall Add support for multiple versions in pyenv uninstall Aug 6, 2022
@native-api native-api merged commit afeb971 into pyenv:master Aug 15, 2022
@native-api
Copy link
Member

Thank you for your efforts! Supporting multiple versions in commands that currently only support one is a feature that has been requested for some time! (Though it's not the most requested one so we weren't focusing on it)
This is a start!

@hardikpnsp hardikpnsp deleted the feature/pyenv-uninstall-multple-versions branch August 16, 2022 16:48
laggardkernel added a commit to laggardkernel/pyenv-virtualenv that referenced this pull request Oct 9, 2022
laggardkernel added a commit to laggardkernel/pyenv-virtualenv that referenced this pull request Oct 9, 2022
native-api pushed a commit to pyenv/pyenv-virtualenv that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'pyenv uninstall' multiple versions

2 participants