Fix get-pip which dropped support for legacy Python #1793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pyenv to continue to support legacy Python builds despite the fact that `get-pip` has dropped support for Python 2 as discussed in pypa/get-pip#87
This was referenced Jan 27, 2021
faximan
added a commit
to faximan/rules_docker
that referenced
this pull request
Feb 2, 2021
…n versions.
The tests are using a base image that only has python3.5 and currently the run_arbitrary tests are failing with
```
stderr: Traceback (most recent call last):
File "/usr/local/bin/pip", line 7, in <module>
from pip._internal.cli.main import main
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/cli/main.py", line 60
sys.stderr.write(f"ERROR: {exc}")
^
SyntaxError: invalid syntax
```
This was fixed upstream in pyenv/pyenv#1793 but it is not clear to me how/when we can expect to see that as part of launcher.gcr.io/google/bazel:latest.
smukherj1
pushed a commit
to bazelbuild/rules_docker
that referenced
this pull request
Feb 2, 2021
…n versions. (#1723) The tests are using a base image that only has python3.5 and currently the run_arbitrary tests are failing with ``` stderr: Traceback (most recent call last): File "/usr/local/bin/pip", line 7, in <module> from pip._internal.cli.main import main File "/usr/local/lib/python3.5/dist-packages/pip/_internal/cli/main.py", line 60 sys.stderr.write(f"ERROR: {exc}") ^ SyntaxError: invalid syntax ``` This was fixed upstream in pyenv/pyenv#1793 but it is not clear to me how/when we can expect to see that as part of launcher.gcr.io/google/bazel:latest.
faximan
added a commit
to faximan/rules_docker
that referenced
this pull request
Feb 2, 2021
…n versions.
The tests are using a base image that only has python3.5 and currently the run_arbitrary tests are failing with
```
stderr: Traceback (most recent call last):
File "/usr/local/bin/pip", line 7, in <module>
from pip._internal.cli.main import main
File "/usr/local/lib/python3.5/dist-packages/pip/_internal/cli/main.py", line 60
sys.stderr.write(f"ERROR: {exc}")
^
SyntaxError: invalid syntax
```
This was fixed upstream in pyenv/pyenv#1793 but it is not clear to me how/when we can expect to see that as part of launcher.gcr.io/google/bazel:latest.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of an f-string in
get-pipbreaks pyenv builds of Python 2.7, 3.4, and 3.5 until this PR (or similar) is landed and released. Fix pyenv to continue to support these legacy Python builds despite the fact thatget-piphas dropped support for Python 2.7 as discussed in pypa/pip#9520 --> pypa/get-pip#87.Also, fix Python 3.4 and 3.5 which also do not support f-strings.
https://bootstrap.pypa.io/
Make sure you have checked all steps below.
Prerequisite
Description
Tests