Add prettier and pygrep hooks to pre-commit hooks#9644
Merged
dcherian merged 10 commits intopydata:mainfrom Nov 18, 2024
Merged
Add prettier and pygrep hooks to pre-commit hooks#9644dcherian merged 10 commits intopydata:mainfrom
dcherian merged 10 commits intopydata:mainfrom
Conversation
max-sixty
reviewed
Oct 18, 2024
max-sixty
reviewed
Oct 18, 2024
max-sixty
reviewed
Oct 18, 2024
max-sixty
reviewed
Oct 18, 2024
Collaborator
|
Overall looks great! We should check some of those, I added a couple of comments, though not a complete review. To the extent that some might interfere with The markdown & rst checkers look overall great! |
keewis
reviewed
Oct 19, 2024
.pre-commit-config.yaml
Outdated
| - repo: https://github.com/executablebooks/mdformat | ||
| rev: 0.7.18 | ||
| hooks: | ||
| - id: mdformat |
Collaborator
There was a problem hiding this comment.
apparently, we can fix (some of) the surprising bracket escapes with
Suggested change
| - id: mdformat | |
| - id: mdformat | |
| additional_dependencies: [mdformat-gfm] |
Collaborator
There was a problem hiding this comment.
though I wonder if instead of using mdformat we should rely on prettier to format markdown, as that can also format json and yaml?
Collaborator
There was a problem hiding this comment.
FWIW in prql we quite successfully use prettier to format all non-core code, including yaml / json / md; would recommend: https://github.com/PRQL/prql/blob/86becc591eb1a6421695ccccdf67dd8ab5c775ec/.pre-commit-config.yaml#L18-L22
...and it has a nice VS Code extension (and I guess emacs for the pros among us...)
Collaborator
|
Why don't we instead try to rely on ruff and enable these rules there? |
Collaborator
Definitely preferable for the python ones. (though formatting non-python files would still be part of this sort of effort...) |
Illviljan
reviewed
Oct 30, 2024
90ea56e to
522e28d
Compare
Contributor
Author
|
Thank you for all your comments, I switched to |
dcherian
reviewed
Nov 17, 2024
dcherian
reviewed
Nov 17, 2024
dcherian
reviewed
Nov 17, 2024
dcherian
reviewed
Nov 17, 2024
dcherian
reviewed
Nov 17, 2024
dcherian
reviewed
Nov 17, 2024
dcherian
reviewed
Nov 17, 2024
dcherian
reviewed
Nov 17, 2024
522e28d to
2537fbf
Compare
keewis
reviewed
Nov 18, 2024
dcherian
reviewed
Nov 18, 2024
dcherian
reviewed
Nov 18, 2024
dcherian
reviewed
Nov 18, 2024
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
dcherian
added a commit
that referenced
this pull request
Nov 19, 2024
* main: (24 commits) Bump minimum versions (#9796) Namespace-aware `xarray.ufuncs` (#9776) Add prettier and pygrep hooks to pre-commit hooks (#9644) `rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (#9720) Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (#9793) Buffer types (#9787) Add download stats badges (#9786) Fix open_mfdataset for list of fsspec files (#9785) add 'User-Agent'-header to pooch.retrieve (#9782) Optimize `ffill`, `bfill` with dask when `limit` is specified (#9771) fix cf decoding of grid_mapping (#9765) Allow wrapping `np.ndarray` subclasses (#9760) Optimize polyfit (#9766) Use `map_overlap` for rolling reductions with Dask (#9770) fix html repr indexes section (#9768) Bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 in the actions group (#9763) unpin array-api-strict, as issues are resolved upstream (#9762) rewrite the `min_deps_check` script (#9754) CI runs ruff instead of pep8speaks (#9759) Specify copyright holders in main license file (#9756) ...
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Nov 19, 2024
* main: Bump minimum versions (pydata#9796) Namespace-aware `xarray.ufuncs` (pydata#9776) Add prettier and pygrep hooks to pre-commit hooks (pydata#9644) `rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (pydata#9720) Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (pydata#9793) Buffer types (pydata#9787) Add download stats badges (pydata#9786) Fix open_mfdataset for list of fsspec files (pydata#9785) add 'User-Agent'-header to pooch.retrieve (pydata#9782) Optimize `ffill`, `bfill` with dask when `limit` is specified (pydata#9771) fix cf decoding of grid_mapping (pydata#9765) Allow wrapping `np.ndarray` subclasses (pydata#9760) Optimize polyfit (pydata#9766) Use `map_overlap` for rolling reductions with Dask (pydata#9770)
wavebyrd
pushed a commit
to wavebyrd/xarray
that referenced
this pull request
Mar 13, 2026
* main: (24 commits) Bump minimum versions (pydata#9796) Namespace-aware `xarray.ufuncs` (pydata#9776) Add prettier and pygrep hooks to pre-commit hooks (pydata#9644) `rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (pydata#9720) Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (pydata#9793) Buffer types (pydata#9787) Add download stats badges (pydata#9786) Fix open_mfdataset for list of fsspec files (pydata#9785) add 'User-Agent'-header to pooch.retrieve (pydata#9782) Optimize `ffill`, `bfill` with dask when `limit` is specified (pydata#9771) fix cf decoding of grid_mapping (pydata#9765) Allow wrapping `np.ndarray` subclasses (pydata#9760) Optimize polyfit (pydata#9766) Use `map_overlap` for rolling reductions with Dask (pydata#9770) fix html repr indexes section (pydata#9768) Bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 in the actions group (pydata#9763) unpin array-api-strict, as issues are resolved upstream (pydata#9762) rewrite the `min_deps_check` script (pydata#9754) CI runs ruff instead of pep8speaks (pydata#9759) Specify copyright holders in main license file (pydata#9756) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #8239. This mainly addresses problems in rst and markdown files.