Accessibility: Add keyboard handling for XArray HTML view#9412
Merged
max-sixty merged 1 commit intopydata:mainfrom Aug 29, 2024
Merged
Accessibility: Add keyboard handling for XArray HTML view#9412max-sixty merged 1 commit intopydata:mainfrom
max-sixty merged 1 commit intopydata:mainfrom
Conversation
The default html view generated via XArray uses hidden checkboxes to achieve collapse expand behaviour. This PR - Makes the hidden checkboxes visible with 0 opacity , to make them accessible via keyboard Make style changes to associated labels for focus, to highlight where the keyboard focus is Change the grid layout to account for the invisible checkboxes
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
Contributor
|
Very nice! Thank you. |
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
Collaborator
|
Thanks @srijan55 ! Any other keyboard shortcuts very welcome! |
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Aug 30, 2024
The default html view generated via XArray uses hidden checkboxes to achieve collapse expand behaviour. This PR - Makes the hidden checkboxes visible with 0 opacity , to make them accessible via keyboard Make style changes to associated labels for focus, to highlight where the keyboard focus is Change the grid layout to account for the invisible checkboxes
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Aug 30, 2024
* main: Accessibility: Add keyboard handling for XArray HTML view (pydata#9412) [pre-commit.ci] pre-commit autoupdate (pydata#9316) [skip-ci] Speed up docs build by limiting toctrees (pydata#9395) fix the failing `pre-commit.ci` runs (pydata#9411) Update benchmarks.yml (pydata#9406) GroupBy(multiple groupers) (pydata#9372) Encode/decode property tests use variables() (pydata#9401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default html view generated via XArray uses hidden checkboxes to achieve collapse expand behaviour. This PR -
Makes the hidden checkboxes visible with 0 opacity , to make them accessible via keyboard Make style changes to associated labels for focus, to highlight where the keyboard focus is Change the grid layout to account for the invisible checkboxes
Video.Project.2.mp4
issue - #9397