Use plt.rc_context for default styles#7318
Merged
Illviljan merged 19 commits intopydata:mainfrom Feb 9, 2023
Merged
Conversation
for more information, see https://pre-commit.ci
Contributor
Author
|
Seaborn did something similar as the original but had a little check if the marker was filled or not: |
…m/Illviljan/xarray into use_rc_context_for_default_styles
headtr1ck
approved these changes
Nov 27, 2022
Collaborator
headtr1ck
left a comment
There was a problem hiding this comment.
Did not check what seaborn is doing exactly, but it seems like a reasonable approach.
mathause
reviewed
Nov 29, 2022
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
dcherian
reviewed
Nov 29, 2022
| plt = import_matplotlib_pyplot() | ||
| if Version(plt.matplotlib.__version__) < Version("3.5.0"): | ||
| ax.view_init(azim=30, elev=30) | ||
| with plt.rc_context(_styles): |
Contributor
There was a problem hiding this comment.
Doesn't this override any user style settings in .matplotlibrc so if they chose a default of black we'd be overwriting that?
Contributor
Author
There was a problem hiding this comment.
Yes, the innermost context takes priority. edgecolor="k" can be used though.
We have the same problem with color maps:
ds = xr.tutorial.scatter_example_dataset(seed=42)
fig, axs = plt.subplots(1, 2)
with plt.rc_context(
{
"scatter.edgecolors": "k",
"image.cmap": "Greys",
}
):
# Normal scatter:
axs[0].scatter(ds.A.values.ravel(), ds.B.values.ravel(), c=3 * ds.B.values)
# xarray scatter:
ds.plot.scatter(x="A", y="B", ax=axs[1])
Contributor
Author
|
This has stalled for long enough. I'll merge this at the end of next week unless someone disagrees, at least it is an improvement to the bugged main. |
dcherian
added a commit
to abel-bzz/xarray
that referenced
this pull request
Feb 28, 2023
* upstream/main: (291 commits) Update error message when saving multiindex (pydata#7475) DOC: cross ref the groupby tutorial (pydata#7555) [pre-commit.ci] pre-commit autoupdate (pydata#7543) supress namespace_package deprecation warning (doctests) (pydata#7548) [skip-ci] Add PDF of Xarray logo (pydata#7530) Support complex arrays in xr.corr (pydata#7392) clarification for thresh arg of dataset.dropna() (pydata#7481) [pre-commit.ci] pre-commit autoupdate (pydata#7524) Require to explicitly defining optional dimensions such as hue and markersize (pydata#7277) Use plt.rc_context for default styles (pydata#7318) Update HOW_TO_RELEASE.md (pydata#7512) Update whats-new for dev (pydata#7511) Fix whats-new for 2023.02.0 (pydata#7506) Update apply_ufunc output_sizes error message (pydata#7509) Zarr: drop "source" and "original_shape" from encoding (pydata#7500) [pre-commit.ci] pre-commit autoupdate (pydata#7507) Whats-new for 2023.03.0 Add `inclusive` argument to `cftime_range` and `date_range` and deprecate `closed` argument (pydata#7373) Make text match code example (pydata#7499) Remove Dask single-threaded setting in tests (pydata#7489) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whats-new.rst