Switch to T_DataArray in .coords#7285
Merged
Illviljan merged 17 commits intopydata:mainfrom Nov 22, 2022
Merged
Conversation
headtr1ck
reviewed
Nov 14, 2022
Illviljan
commented
Nov 16, 2022
Comment on lines
+372
to
373
| def __getitem__(self, key: Hashable) -> T_DataArray: | ||
| return self._data._getitem_coord(key) |
Contributor
Author
There was a problem hiding this comment.
xarray/core/coordinates.py:372: error: A function returning TypeVar should receive at least one argument containing the same Typevar [type-var]
xarray/core/coordinates.py:372: note: Consider using the upper bound "DataArray" insteadI don't really understand this error, why should the method have at least one argument with the same TypeVar? The TypeVar is stored in self already.
Collaborator
There was a problem hiding this comment.
That's what I meant with making coordinates a generic class.
Contributor
Author
There was a problem hiding this comment.
Sorry, I'm not following. Feel free to push to this PR or link me to an example you think is similar.
Collaborator
There was a problem hiding this comment.
Ok, nvmd. This does not seem to work in python 3.8....
Anyone has an idea how to solve this? haha.
Contributor
Author
There was a problem hiding this comment.
Yeah, a little surprised it worked. :D
Taken from:
https://github.com/python/cpython/blob/b0e1f9c241cd8f8c864d51059217f997d3b792bf/Lib/_collections_abc.py#L428
Collaborator
There was a problem hiding this comment.
Does it work though? What does a reveal_type(da.coords) give?
Or a reveal_type(da.coords["x"])?
Contributor
Author
There was a problem hiding this comment.
I get this on main:
da = xr.DataArray()
reveal_type(da) # note: Revealed type is "Any"Do you as well?
Collaborator
There was a problem hiding this comment.
No, I get note: Revealed type is "xarray.core.dataarray.DataArray" as expected.
(python 3.9.13 and mypy 0.990)
Contributor
Author
There was a problem hiding this comment.
Hmm, I use:
mypy 0.982 py310h8d17308_0 conda-forge
mypy_extensions 0.4.3 py310h5588dad_5 conda-forge
...
python 3.10.6 h9a09f29_0_cpython conda-forge
Contributor
Author
|
Mypy errors with python 3.8. Doesn't appear related to this PR at least. |
Collaborator
|
See #6963 for python 3.8 |
headtr1ck
approved these changes
Nov 21, 2022
Collaborator
|
Just noticed that now pylance and mypy return "Any" as Value types. |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Dec 2, 2022
* upstream/main: (39 commits) Support the new compression argument in netCDF4 > 1.6.0 (pydata#6981) Remove setuptools-scm-git-archive, require setuptools-scm>=7 (pydata#7253) Fix mypy failures (pydata#7343) Docs: add example of writing and reading groups to netcdf (pydata#7338) Reset file pointer to 0 when reading file stream (pydata#7304) Enable mypy warn unused ignores (pydata#7335) Optimize some copying (pydata#7209) Add parse_dims func (pydata#7051) Fix coordinate attr handling in `xr.where(..., keep_attrs=True)` (pydata#7229) Remove code used to support h5py<2.10.0 (pydata#7334) [pre-commit.ci] pre-commit autoupdate (pydata#7330) Fix PR number in what’s new (pydata#7331) Enable `origin` and `offset` arguments in `resample` (pydata#7284) fix doctests: supress urllib3 warning (pydata#7326) fix flake8 config (pydata#7321) implement Zarr v3 spec support (pydata#6475) Fix polyval overloads (pydata#7315) deprecate pynio backend (pydata#7301) mypy - Remove some ignored packages and modules (pydata#7319) Switch to T_DataArray in .coords (pydata#7285) ...
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.coords were still using DataArray types switch to T_DataArray instead.