Added suppport for geotiff colormap() colorinterp to be loaded into attrs#3136
Closed
alando46 wants to merge 2 commits intopydata:mainfrom
alando46:colormap-colorinterp
Closed
Added suppport for geotiff colormap() colorinterp to be loaded into attrs#3136alando46 wants to merge 2 commits intopydata:mainfrom alando46:colormap-colorinterp
alando46 wants to merge 2 commits intopydata:mainfrom
alando46:colormap-colorinterp
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3136 +/- ##
==========================================
- Coverage 95.99% 95.05% -0.95%
==========================================
Files 63 63
Lines 12799 12803 +4
==========================================
- Hits 12287 12170 -117
- Misses 512 633 +121 |
Contributor
|
I think we'd like to load all possible attrs and make them accessible if it's easy to do so. Is there a way to do that without having to explicitly add each one? |
Author
|
@dcherian that makes sense to me and shouldn't be difficult to do. I basically just tried to follow the existing design pattern for the other attributes. |
Collaborator
|
related to #4697: now that we consider deprecating |
Contributor
|
Related: corteva/rioxarray#191 |
weiji14
added a commit
to weiji14/rioxarray
that referenced
this pull request
Oct 1, 2021
Cherry-picked from pydata/xarray#3136 Co-Authored-By: Alando Ballantyne <alando@radiant.earth>
3 tasks
Contributor
|
Should be fixed in rioxarray since we've now deprecated open_raserio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is tangentially related to the
to_geotiff()discussion.We're using intake-xarray to read a year's worth of Sentinel-2 Scene Classification Layers into a DataArray, doing some processing, and then writing the output to a single band GeoTIFF. When writing the output, we'd like to preserve the colormap of the original underlying data.
xarray-intakeusesxarrayto read the dataset, so thought it might be useful to add support inopen_rasterio()to read and loadsrc.colormap(1)andsrc.colorinterpinto the attributes of the DataArray. My thinking is that if in the future the community ends up wanting to add ato_geotiff()method, reading thesrccolormap and colorinterp might be useful.Before adding tests, I thought I'd submit the PR to see what others thought about adding this functionality. If there's support for this, I'm happy to add any needed tests or documentation.
whats-new.rstfor all changes andapi.rstfor new API