⚡️ Speed up function apply_each_item_validators by 100% in pydantic/_internal/_generate_schema.py#9950
Merged
sydney-runkle merged 5 commits intopydantic:mainfrom Jul 30, 2024
Conversation
Below is an optimized version of the same Python program. The changes aim to improve execution speed by reducing redundant operations and simplifying some parts of the code. ### Changes Made. 1. **Use of `slots` in `dataclass`**: Added `slots=True` to the `ValidatorDecoratorInfo` and `Decorator` classes to reduce memory usage. 2. **Streamlined `build` method**: Consolidated the logic within the `build` method to streamline function unwrapping and avoid repeated code. 3. **Avoid Redundant Type Checking**: In `apply_each_item_validators`, added a quick return if `each_item_validators` is empty. 4. **Simplified Schema Handling**: Minimized redundant dictionary key accesses and introduced the use of `get` with default values. These optimizations should enhance the performance and maintainability of the code without changing its external behavior.
CodSpeed Performance ReportMerging #9950 will not alter performanceComparing Summary
|
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Happy with this overall, one change request.
I'm not seeing super major performance benefits across our benchmarks, but those can certainly be expanded. Happy to accept this as a general improvement.
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
sydney-runkle
approved these changes
Jul 30, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Looks good now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
📄
apply_each_item_validators()inpydantic/_internal/_generate_schema.py📈 Performance improved by
100%(1.00xfaster)⏱️ Runtime went down from
108 microsecondsto54.1 microsecondsExplanation and details
Below is an optimized version of the same Python program. The changes aim to improve execution speed by reducing redundant operations and simplifying some parts of the code.
Changes Made.
apply_each_item_validators, added a quick return ifeach_item_validatorsis empty.getwith default values.These optimizations should enhance the performance and maintainability of the code without changing its external behavior.
This optimization was automatically discovered with codeflash.ai
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 0 Passed − 🌀 Generated Regression Tests
✅ 200 Passed − ⏪ Replay Tests
Checklist