Support context being passed to TypeAdapter's dump_json/dump_python#9495
Merged
sydney-runkle merged 1 commit intopydantic:mainfrom May 28, 2024
Merged
Support context being passed to TypeAdapter's dump_json/dump_python#9495sydney-runkle merged 1 commit intopydantic:mainfrom
sydney-runkle merged 1 commit intopydantic:mainfrom
Conversation
CodSpeed Performance ReportMerging #9495 will not alter performanceComparing Summary
|
900b78f to
245ac01
Compare
3 tasks
sydney-runkle
approved these changes
May 28, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Amazing, thanks!
This looks great.
Contributor
Author
|
@sydney-runkle if I recreate this PR against Created here: #9553 in case it's allowed |
alexcouper
added a commit
to alexcouper/pydantic
that referenced
this pull request
Jun 3, 2024
5 tasks
Contributor
|
We generally just do bug fixes in patch releases, so we'll keep this in 2.8! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Support passing in of context to
TypeAdapter'sdump_pythonanddump_jsonfunctions, allowing context to be present during TypeAdapter serialization.Related issue number
No related issue, but I can create one if required. Seems like this change fits into "trivial change", but I may be missing some context of my own.
Issue I'm solving for is that I want to be able to serialize an object in different contexts (using fastapi), so this piece is needed to support context based serialization of type adapters.
The upstream problem this solves (in fastapi) is illustrated here: fastapi/fastapi#11634
Checklist