Do not alter RootModel.model_construct signature in the mypy plugin#9480
Merged
sydney-runkle merged 1 commit intopydantic:mainfrom May 22, 2024
Merged
Conversation
CodSpeed Performance ReportMerging #9480 will not alter performanceComparing Summary
|
5e209a1 to
b439811
Compare
b439811 to
7a2fd1e
Compare
sydney-runkle
approved these changes
May 22, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
This looks like a good fix, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9461.
No need to tweak the signature as no
**valuesargument is present