Skip to content

Increase test coverage of the fields module#9470

Merged
sydney-runkle merged 1 commit intopydantic:mainfrom
vbmendes:increase_fields_test_coverage
May 21, 2024
Merged

Increase test coverage of the fields module#9470
sydney-runkle merged 1 commit intopydantic:mainfrom
vbmendes:increase_fields_test_coverage

Conversation

@vbmendes
Copy link
Copy Markdown
Contributor

Change Summary

This PR adds test coverage to two uncovered test scenarios:

  • Computed fields with the deprecated attribute set to True
  • Computed fields with the deprecated attribute set to a str instance.

Related issue number

Contributes to #7656

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions Bot added the relnotes-fix Used for bugfixes. label May 21, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 21, 2024

CodSpeed Performance Report

Merging #9470 will not alter performance

Comparing vbmendes:increase_fields_test_coverage (4101675) with main (9030415)

Summary

✅ 13 untouched benchmarks

Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sydney-runkle sydney-runkle enabled auto-merge (squash) May 21, 2024 15:05
@sydney-runkle sydney-runkle merged commit f356552 into pydantic:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants