CodSpeed Performance Report

Merging #9293 will not alter performance

_{Comparing idan22moral:hide-private-attrs-in-init (d853bd4) with main (131cfa7)}

Summary

✅ 13 untouched benchmarks

please review :)

That's a great fix, was first worried this was unspecified behavior that pyright happened to support, but is it indeed explicitly specified by PEP 681:

init is an optional bool parameter that indicates whether the field should be included in the synthesized __init__ method. If unspecified, init defaults to True. Field specifier functions can use overloads that implicitly specify the value of init using a literal bool value type (Literal[False] or Literal[True]).

This will not handle the case where PrivateAttr isn't used:

class Model(BaseModel):
    _priv: int

Model()  # type error, ok at runtime

But we are limited by what @dataclass_transform provides.

Checked and this is also supported by mypy.

I think it's best to leave the v1 bundle untouched, @sydney-runkle what do you think?

@idan22moral

Great work here. Love the fix.

I think it's best to leave the v1 bundle untouched, @sydney-runkle what do you think?

Agreed, let's revert those changes! Otherwise, looks ready to roll! Thanks @idan22moral for some clever and great work on this!

Agreed, let's revert those changes! Otherwise, looks ready to roll! Thanks @idan22moral for some clever and great work on this!

@sydney-runkle Awesome! Thanks for the kind words 😊

I removed the v1 changes, rebased and force-pushed to preserve the clean history.
I'm marking the PR as ready for review so you can merge it.

Just making sure - are we good on the init: Literal[False] = False part?
It's not the cleanest of solutions, but I couldn't come up with something better (considering PEP 681).

Just making sure - are we good on the init: Literal[False] = False part?
It's not the cleanest of solutions, but I couldn't come up with something better (considering PEP 681).

Yep, I'm ok with this. I think it's a good solution for now. We also have some time before the next minor release to change things up a bit if needed!