Fix model json schema with config types#9287
Merged
sydney-runkle merged 2 commits intopydantic:mainfrom Apr 22, 2024
Merged
Conversation
CodSpeed Performance ReportMerging #9287 will not alter performanceComparing Summary
|
Contributor
Author
|
Please review |
sydney-runkle
approved these changes
Apr 22, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Great work @NeevCohen. Awesome test as well. Merging now, this fix will be included in 2.7.1 soon!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixing an issue where a model would have a field with a default value being a pydantic type (
BaseModel,datacalass,TypedDict), then generating the parent model's json schema would fail.Related issue number
Fix #9253
Checklist
Selected Reviewer: @dmontagu