Skip to content

Add support for field level number to str coercion option#9137

Merged
sydney-runkle merged 5 commits intopydantic:mainfrom
NeevCohen:feature/field-level-number-to-str-coercion
Apr 11, 2024
Merged

Add support for field level number to str coercion option#9137
sydney-runkle merged 5 commits intopydantic:mainfrom
NeevCohen:feature/field-level-number-to-str-coercion

Conversation

@NeevCohen
Copy link
Copy Markdown
Contributor

@NeevCohen NeevCohen commented Mar 29, 2024 •
edited by sydney-runkle
Loading

Change Summary

This change adds support for field level number to str coercion option as requested in #8383.

Support in pydantic-core has already been implemented in pydantic/pydantic-core@c607fd8.

This change requires a new pydantic-core version which includes the above commit. Opening this PR now to remember to merge it once a new core version comes out.

Related issue number

Fix #8383

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@NeevCohen NeevCohen mentioned this pull request Mar 29, 2024
Closed
13 tasks
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9137 will not alter performance

Comparing NeevCohen:feature/field-level-number-to-str-coercion (b4784ea) with main (932b025)

Summary

✅ 13 untouched benchmarks

sydney-runkle
sydney-runkle approved these changes Apr 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Approving now, will merge once we get that new core version ready :).

@NeevCohen
Copy link
Copy Markdown
Contributor Author

NeevCohen commented Apr 2, 2024

@sydney-runkle Awesome! Thanks a lot! Just need to remember to remove the xfails from the tests 😄

@sydney-runkle
Copy link
Copy Markdown
Contributor

sydney-runkle commented Apr 2, 2024

@NeevCohen,

Once we merge this PR #9153, you can pull that change in and remove your xfails!

@sydney-runkle
Copy link
Copy Markdown
Contributor

sydney-runkle commented Apr 2, 2024

@NeevCohen, that PR is now merged!

sydney-runkle
sydney-runkle reviewed Apr 3, 2024
View reviewed changes
Comment thread tests/test_fields.py Outdated
sydney-runkle
sydney-runkle reviewed Apr 3, 2024
View reviewed changes
Comment thread tests/test_fields.py Outdated
@sydney-runkle
Copy link
Copy Markdown
Contributor

sydney-runkle commented Apr 3, 2024

@NeevCohen,

Hmm, looks like tests are still failing...

@sydney-runkle
Copy link
Copy Markdown
Contributor

sydney-runkle commented Apr 3, 2024

Going to go ahead and release 2.7 beta, but we can get this across the line this week + get it into the official release :).

@NeevCohen
Copy link
Copy Markdown
Contributor Author

NeevCohen commented Apr 3, 2024

@sydney-runkle I figured out the issue. In core, I forgot to add the corece_numbers_to_str option in the StringSchema typed dict. Sorry for that, my bad.

I opened a PR fixing that issue, pydantic/pydantic-core#1262

@NeevCohen NeevCohen mentioned this pull request Apr 3, 2024
Merged
4 tasks
@sydney-runkle
Copy link
Copy Markdown
Contributor

sydney-runkle commented Apr 3, 2024

Awesome, no worries at all. We can get that into the next pydantic-core release, which we'll include in 2.7!

@sydney-runkle
Copy link
Copy Markdown
Contributor

sydney-runkle commented Apr 11, 2024 •
edited
Loading

@NeevCohen,

Could you pull in the changes from main once #9211 merges? Should be in just a few minutes :).

Edit: I'll save you the trouble and do the merge :)

@sydney-runkle
Copy link
Copy Markdown
Contributor

sydney-runkle commented Apr 11, 2024

I'll review your other PR shortly - looking forward to it!! Just want to get 2.7 out first :).

@sydney-runkle sydney-runkle enabled auto-merge (squash) April 11, 2024 14:25
@sydney-runkle sydney-runkle merged commit 99821e9 into pydantic:main Apr 11, 2024
@NeevCohen NeevCohen deleted the feature/field-level-number-to-str-coercion branch April 17, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

relnotes-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

coerce_numbers_to_str needs a per-field variant

2 participants

@NeevCohen @sydney-runkle