Ensure json-schema generator handles Literal Null types#9135
Merged
sydney-runkle merged 3 commits intopydantic:mainfrom Apr 2, 2024
Merged
Ensure json-schema generator handles Literal Null types#9135sydney-runkle merged 3 commits intopydantic:mainfrom
sydney-runkle merged 3 commits intopydantic:mainfrom
Conversation
1 task
CodSpeed Performance ReportMerging #9135 will not alter performanceComparing Summary
|
Contributor
Author
|
please review @sydney-runkle Not sure why those 3 tests are failing, can you take a look? thanks! |
Contributor
|
Looked like flaky CI. All is well! |
sydney-runkle
approved these changes
Apr 2, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Waiting for final confirmation from @dmontagu before we merge.
NeevCohen
pushed a commit
to NeevCohen/pydantic
that referenced
this pull request
Apr 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR aims to complete #8944 and #8905 by also handling null types when generating a json-schema from a pydantic model.
For instance, the following model:
leads to:
Related issue number
fix #8905
Checklist
Selected Reviewer: @adriangb