CodSpeed Performance Report

Merging #9114 will improve performances by 53.81%

_{Comparing make_schema_gen_better (ee3ebfb) with main (548feec)}

Summary

⚡ 1 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Please review

This is very nice!

Do we have any benchmarks? That'd be a nice to have so we can track this. Assuming you wrote some to come up with this change, can we commit them along with other benchmarks (if they don't already exist)?

There's several scenarios where I imagine we do need to rebuild:

# unsubstituted typevars
class Inner(BaseModel, Generic[T]):
    x: T

class Outer(BaseModel):
    inner: Inner[int]  # need to rebuild innner

# cyclical forward references
class InnerFwd(BaseModel):
    outer: OuterFwd

class OuterFwd(BaseModel):
    inner: InnerFwd

And probably others I'm not thinking of. Do we have tests showing that these use cases work correctly?

Deploying pydantic-docs with    Cloudflare Pages

View logs

@adriangb,

There's several scenarios where I imagine we do need to rebuild

Good point - I've added tests for both of these cases both to test_main.py and test_dataclasses.py. Interestingly, the generic handling is different for dataclasses vs models (re concrete subclasses), but I think that's something we can address separately (and loop in @dmontagu).

Do we have any benchmarks? That'd be a nice to have so we can track this.

I've added a benchmark for the basic case with a nested model and dataclass. I think this should work, though I might have to add this in a separate PR so that we get a comparison in main before we merge this...

Ah, added this to a separate PR: #9121