Skip to content

More helpful error re wrong model_json_schema usage#8928

Merged
sydney-runkle merged 2 commits intomainfrom
json-schema-helpful-error
Mar 1, 2024
Merged

More helpful error re wrong model_json_schema usage#8928
sydney-runkle merged 2 commits intomainfrom
json-schema-helpful-error

Conversation

@sydney-runkle
Copy link
Copy Markdown
Contributor

@sydney-runkle sydney-runkle commented Mar 1, 2024

Fix #8896

Selected Reviewer: @davidhewitt

@sydney-runkle
Copy link
Copy Markdown
Contributor Author

Please review

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 1, 2024

CodSpeed Performance Report

Merging #8928 will not alter performance

Comparing json-schema-helpful-error (1794dcd) with main (db0f809)

Summary

✅ 10 untouched benchmarks

Comment thread pydantic/json_schema.py Outdated
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Mar 1, 2024
@sydney-runkle sydney-runkle merged commit e1a5c18 into main Mar 1, 2024
@sydney-runkle sydney-runkle deleted the json-schema-helpful-error branch March 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssertionError when calling BaseModel.schema_json()

3 participants