Test mypy integration with pytest#735
Merged
samuelcolvin merged 6 commits intopydantic:masterfrom Aug 17, 2019
Merged
Conversation
dmontagu
commented
Aug 11, 2019
dmontagu
commented
Aug 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 2723 2723
Branches 536 536
=====================================
Hits 2723 2723 |
Member
samuelcolvin
left a comment
There was a problem hiding this comment.
LGTM, do you want to remove external-mypy now?
Member
|
maybe I'm being dumb, but I thought we could remove |
Contributor
Author
|
@samuelcolvin Just pushed with external-mypy removed from makefile and CI |
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
In preparation for integrating a mypy plugin, I've refactored the mypy tests to be called via
mypy.api.runthrough pytest.I see several benefits to this:
Related issue number
@samuelcolvin Given this shouldn't have any effects on external usage of the library, I figured this pull request would be the right place for discussion, but let me know if you'd like me to open a separate issue.
Checklist
changes/<pull request or issue id>-<github username>.rstfile added describing change(see changes/README.md for details)