Fix alias_generator and field config conflict#658
Merged
samuelcolvin merged 6 commits intopydantic:masterfrom Jul 24, 2019
Merged
Fix alias_generator and field config conflict#658samuelcolvin merged 6 commits intopydantic:masterfrom
samuelcolvin merged 6 commits intopydantic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 2712 2712
Branches 537 537
=====================================
Hits 2712 2712 |
Contributor
Author
|
@gmetzker, check this out please :) |
samuelcolvin
approved these changes
Jul 15, 2019
Member
samuelcolvin
left a comment
There was a problem hiding this comment.
LGTM, just rebase and update HISTORY I'm afraid (sorry, will move to towncrier or similar soon).
I tried your branch and it indeed fixed the issue. Thx @MrMrRobat |
Contributor
Author
|
@samuelcolvin, I gues we ready for merge! |
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
alias_generatorwill work if field has extra values in schema, but no'alias'specifiedRelated issue number
#645
Checklist
HISTORY.rsthas been updated#<number>@<whomever>